Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Propagate signature-modifying decorators to pyplot wrappers.#15254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:propagate-decorators
Mar 22, 2020

Conversation

anntzer
Copy link
Contributor

PR Summary

alternative to#14130, see discussion there; attn@timhoffm

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffmtimhoffm mentioned this pull requestJan 11, 2020
13 tasks
@anntzeranntzerforce-pushed thepropagate-decorators branch 3 times, most recently frome8597f7 toce1eed0CompareFebruary 26, 2020 14:11
@ksunden
Copy link
Member

What is the disposition on this PR (asking in relation to#15049)? Looks like the conflict is in generated code, and can be resolved rather simply.

@timhoffm
Copy link
Member

There's no final decision between this and#14130 yet. In the end, I don't have a very strong opinion anymore on which one to choose. The important thing is that we get one of them in, so that we can properly rename parameters and propagate that to pyplot. Since this is internal functionality, we could even switch out the solution if we realize the other one was better.

In practice, we need a second positive review so that this can get merged. The confict is indeed trivial to solve by regenerating the code.

@anntzer
Copy link
ContributorAuthor

rebased

@QuLogic
Copy link
Member

I want to merge, but I'm wondering if there's an example that would trigger this yet?

@ksunden
Copy link
Member

@QuLogic I think there are others, but one such example is thes argument toplt.annotate being changed totext (See#15049, as that change is also required for this example)

The argument (and docstring) were changed in the actual implementation, but pyplot still has the old kwarg (with the new docstring)

@QuLogicQuLogic merged commite92685a intomatplotlib:masterMar 22, 2020
@QuLogicQuLogic added this to thev3.3.0 milestoneMar 22, 2020
@anntzeranntzer deleted the propagate-decorators branchMarch 22, 2020 09:52
ksunden added a commit to ksunden/matplotlib that referenced this pull requestMar 26, 2020
Remove specification for where the old parameter remains supportedThis was fixed by mergingmatplotlib#15254
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@ksunden@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp