Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Cleanup font_manager.#15250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Cleanup font_manager.#15250
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Reword FontManager docstring.- Fix incorrect doc for rebuild_if_missing paramter to findfont.- Pass fallback_to_default/rebuild_if_missing as explicit keyword arguments, rather than positionally (``True, False`` is just too hard to read).
| does a nearest neighbor search to find the font that most closely | ||
| matches the specification. If no good enough match is found, a | ||
| default font is returned. | ||
| On import, the `FontManager` singleton instance creates a list of ttf and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These refs need leading., no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no, because we're refering to stuff in the same module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That is correct. Personally, I put dots almost everywhere because I usually don't know or care to check if the the reference lives in the same module.
arguments, rather than positionally (
True, Falseis just too hardto read).
PR Summary
PR Checklist