Mar 14, 2020 · Sep 7, 2019 · Sep 7, 2019 · Sep 7, 2019 · Sep 7, 2019
diff --git a/lib/matplotlib/backends/backend_pdf.py b/lib/matplotlib/backends/backend_pdf.py
    ----------
    figure : `matplotlib.figure.Figure`
        A high-level Figure instance

    """

    fixed_dpi = 72

    def draw(self):
        pass

    filetypes = {'pdf': 'Portable Document Format'}

    def get_default_filetype(self):
diff --git a/lib/matplotlib/backends/backend_pgf.py b/lib/matplotlib/backends/backend_pgf.py
        return RendererPgf(self.figure, None, dummy=True)


 class FigureManagerPgf(FigureManagerBase):
    pass
 FigureManagerPgf = FigureManagerBase


 @_Backend.export
 class _BackendPgf(_Backend):
    FigureCanvas = FigureCanvasPgf
    FigureManager = FigureManagerPgf


 def _cleanup_all():
diff --git a/lib/matplotlib/backends/backend_ps.py b/lib/matplotlib/backends/backend_ps.py

 class FigureCanvasPS(FigureCanvasBase):
    fixed_dpi = 72

    def draw(self):
        pass

    filetypes = {'ps': 'Postscript',
                 'eps': 'Encapsulated Postscript'}

diff --git a/lib/matplotlib/backends/backend_qt5.py b/lib/matplotlib/backends/backend_qt5.py
        _create_qApp()
        super().__init__(figure=figure)

        self.figure = figure
        # We don't want to scale up the figure DPI more than once.
        # Note, we don't handle a signal for changing DPI yet.
        figure._original_dpi = figure.dpi
diff --git a/lib/matplotlib/backends/backend_template.py b/lib/matplotlib/backends/backend_template.py

    # If the file type is not in the base set of filetypes,
    # you should add it to the class-scope filetypes dictionary as follows:
    filetypes = FigureCanvasBase.filetypes.copy()
    filetypes['foo'] = 'My magic Foo format'
    filetypes = {**FigureCanvasBase.filetypes, 'foo': 'My magic Foo format'}

    def print_foo(self, filename, *args, **kwargs):
        """
diff --git a/lib/matplotlib/backends/backend_wx.py b/lib/matplotlib/backends/backend_wx.py

    def __init__(self, parent, id, figure):
        """
 Initialise a FigureWx instance.
 Initialize a FigureWx instance.

        - Initialise the FigureCanvasBase and wxPanel parents.
        - Set event handlers for:
          EVT_SIZE  (Resize event)
          EVT_PAINT (Paint event)
        - Initialize the FigureCanvasBase and wxPanel parents.
        - Set event handlers for resize, paint, and keyboard and mouse
          interaction.
        """

        FigureCanvasBase.__init__(self, figure)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2498,14 +2498,9 @@ class FigureCanvasPdf(FigureCanvasBase):
		----------
		figure : `matplotlib.figure.Figure`
		A high-level Figure instance

		"""

		fixed_dpi = 72

		def draw(self):
		pass

		filetypes = {'pdf': 'Portable Document Format'}

		def get_default_filetype(self):
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -952,14 +952,12 @@ def get_renderer(self):
		return RendererPgf(self.figure, None, dummy=True)


		class FigureManagerPgf(FigureManagerBase):
		pass
		FigureManagerPgf = FigureManagerBase
Copy link Member timhoffmSep 7, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I wouldn't do this because you don't create a`FigureManagerPgf` type with that, so that `>>> mgr = FigureManagerPgf()>>> type(mgr)<class 'FigureManagerBase'>` which is a bit confusing. Copy link ContributorAuthor anntzerSep 7, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. this is consistent with FigureManagerPS, FigureManagerPDF and FigureManagerSVG, and was discussed in#9551 (review). Copy link Member timhoffmSep 7, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Still not convinced this is a good approach, but accepting as precedenced.


		@_Backend.export
		class _BackendPgf(_Backend):
		FigureCanvas = FigureCanvasPgf
		FigureManager = FigureManagerPgf


		def _cleanup_all():
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -748,10 +748,6 @@ def swap_if_landscape(self, shape):

		class FigureCanvasPS(FigureCanvasBase):
		fixed_dpi = 72

		def draw(self):
		pass

		filetypes = {'ps': 'Postscript',
		'eps': 'Encapsulated Postscript'}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -222,7 +222,6 @@ def __init__(self, figure):
		_create_qApp()
		super().__init__(figure=figure)

		self.figure = figure
		# We don't want to scale up the figure DPI more than once.
		# Note, we don't handle a signal for changing DPI yet.
		figure._original_dpi = figure.dpi
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -200,8 +200,7 @@ def draw(self):

		# If the file type is not in the base set of filetypes,
		# you should add it to the class-scope filetypes dictionary as follows:
		filetypes = FigureCanvasBase.filetypes.copy()
		filetypes['foo'] = 'My magic Foo format'
		filetypes = {**FigureCanvasBase.filetypes, 'foo': 'My magic Foo format'}

		def print_foo(self, filename, args, *kwargs):
		"""
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -512,12 +512,11 @@ class _FigureCanvasWxBase(FigureCanvasBase, wx.Panel):

		def __init__(self, parent, id, figure):
		"""
		Initialise a FigureWx instance.
		Initialize a FigureWx instance.

		- Initialise the FigureCanvasBase and wxPanel parents.
		- Set event handlers for:
		EVT_SIZE (Resize event)
		EVT_PAINT (Paint event)
		- Initialize the FigureCanvasBase and wxPanel parents.
		- Set event handlers for resize, paint, and keyboard and mouse
		interaction.
		"""

		FigureCanvasBase.__init__(self, figure)
Expand Down