NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Explicitly list allowed "unused" imports, remove the rest.#15210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 1 commit intomatplotlib:masterfromanntzer:unusedimports

Oct 1, 2019

Merged

Explicitly list allowed "unused" imports, remove the rest.#15210

jklymak merged 1 commit intomatplotlib:masterfromanntzer:unusedimports

Oct 1, 2019

Conversation

Copy link

Contributor

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Explicitly list allowed "unused" imports, remove the rest.

a7ccc22

anntzer force-pushed theunusedimports branch from175edc1 toa7ccc22Compare

September 7, 2019 10:53

QuLogic approved these changes

Sep 8, 2019

View reviewed changes

Copy link

Member

jklymak commentedOct 1, 2019

So why do those files keep their "unused" imports?

Copy link

ContributorAuthor

Because they are effectively public API (you can import TextPath from matplotlib.text, even though you should really import it from matplotlib.textpath; or, for the constants in matplotlib._image, matplotlib.imageis the public place from which you can import them).