Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Don't generate individual doc entries for inherited Axes/Axis/Tick methods#14960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
IIRC, I added these to make sure that we had targets for the auto-reference links sphinx will generate. |
Does sphinx not link to the parent class as necessary? Well, we can always wait for#14768 to be merged first and we'll see whether this PR breaks the doc build. |
34720c9 to4b04e2fComparebc18ac4 toa4c914fCompareHad to fix just a couple of missing references: Axis refers to its axes property but that's something that numpydoc does automatically and can't be tuned; I also changed the auto-rst table gen to link to the correct parent method which provides the docstring, when it is inherited. |
9a0bde7 to8e5a042CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I am sold on making those pages more readable (by including less noise). Slightly concerned about bit rot / overlapping docs if we remove these build products that problem is already. 👍, but we need to rebuild the missing references. |
rebased |
This looks about ready, but all the doc builds failing is probably not good... |
…thods.These methods directly pass through to the superclass and don't warranttheir own page (having a doc page for Tick.add_callback that justreproes the docstring of Artist.add_callback doesn't add much, and mayin fact make things more confusing for the reader ("oh, it's separatelydocumented here, perhaps it does something special?").Also note that the docs for other Artist subclasses (e.g. Line2D,AxesImage, etc.) don't bother repeating these either.In particular, the property table for artists was changed to point linksto the parent method which actually provides the docstring, if thedocstring is inherited.
let's see if this fixes it... |
These methods directly pass through to the superclass and don't warrant
their own page (having a doc page for Tick.add_callback that just
reproes the docstring of Artist.add_callback doesn't add much, and may
in fact make things more confusing for the reader ("oh, it's separately
documented here, perhaps it does something special?").
Also note that the docs for other Artist subclasses (e.g. Line2D,
AxesImage, etc.) don't bother repeating these either.
attn@tacaswell who added these (together with the non-inherited methods, which should definitely be kept) in#7176.
This may also improve a bit the ci build, as this means ~20-25%(!) fewer API pages...
PR Summary
PR Checklist