Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: update axes_demo to directly manipulate fig, ax#14934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 2 commits intomatplotlib:masterfromCarreau:update_axes_demo
Aug 1, 2019

Conversation

Carreau
Copy link
Contributor

@CarreauCarreau commentedJul 30, 2019
edited
Loading

PR Summary

Directly call method on each individual axis; instead of the global
plt. one, same to create inset; directly refer to the figure on
which wee create an inset.

I also use some more explicit renaming for each axis,
and remove assignments on the LHS when those were unused as it seem like
a distraction on the subject at hand.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Directly call method on each individual axis; instead of the global``plt.`` one, same to create inset; directly refer to the figure onwhich wee create an inset.I also use some more explicit renaming for each axis,and remove assignments on the LHS when those were unused as it seem likea distraction on the subject at hand.
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can this PR also make reference toax.inset_axes and the axes grid one, just so folks have the other ways to do this automagically?

@Carreau
Copy link
ContributorAuthor

make reference to

You mean Just refer to it in the leading text ? Or use them in the code. Can we use ":ref:" with examples ?

@Carreau
Copy link
ContributorAuthor

To answer myself likelyyes

Our namespace convention is to prefix everything with sphx_glr and change path separators with underscores. This is valid for cross-references labels, and images.

@anntzer
Copy link
Contributor

Prefer :doc: to :ref:, per#11312.

@Carreau
Copy link
ContributorAuthor

Can this PR also make reference toax.inset_axes and the axes grid one, just so folks have the other ways to do this automagically?

Prefer :doc: to :ref:, per#11312.

Done.

@anntzeranntzer merged commit9affee4 intomatplotlib:masterAug 1, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 1, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 1, 2019
@CarreauCarreau deleted the update_axes_demo branchAugust 1, 2019 16:12
@Carreau
Copy link
ContributorAuthor

Thanks.

QuLogic added a commit that referenced this pull requestAug 1, 2019
…934-on-v3.1.1-docBackport PR#14934 on branch v3.1.1-doc (DOC: update axes_demo to directly manipulate fig, ax)
QuLogic added a commit that referenced this pull requestAug 1, 2019
…934-on-v3.1.xBackport PR#14934 on branch v3.1.x (DOC: update axes_demo to directly manipulate fig, ax)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.1-doc
Development

Successfully merging this pull request may close these issues.

4 participants
@Carreau@anntzer@jklymak@ImportanceOfBeingErnest

[8]ページ先頭

©2009-2025 Movatter.jp