Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix tests with pandas 0.25#14858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
#13304 explicitly deregistered the converters so we could test thatour converters work on pandas objects. Are you saying our converters no longer work on pandas objects on 0.25? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
blocking because I think we want to fix he root cause, not go back to registering pandas converters (unless we want to maintain them 😉)
Ah sorry, did not realise that. Yes, the reason the tests are failing now is because a pandas dtype isn't being converted properly any more. |
From pandas 0.25 onwards the converters have to be explicitly registered or a warning is raised. I'm guessing they were never meant to bederegistered for the tests, so I've just changed that bit. Someone else may know better though?