Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

More cleanups.#14845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:inverted
Jul 19, 2019
Merged

More cleanups.#14845

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:inverted
Jul 19, 2019

Conversation

anntzer
Copy link
Contributor

  • transformA + transformB.inverted() ===transformA - transformB,
    and give the result a more meaningful name.
  • Other cleanups in axislines.py (which used the above pattern quite a
    bit).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby
Copy link
Member

@anntzer can you try and work out why codecov isn't showing up on any of your PRs? I don't really want to review any until it returns...

@anntzer
Copy link
ContributorAuthor

I don't know why they don't show up on the gh interface, but they're actually being run; this PR is athttps://codecov.io/gh/matplotlib/matplotlib/commit/2b4a3af41cb1168ef137efe5a2c052c3c735007d (you can find them under "recent commits" athttps://codecov.io/gh/matplotlib/matplotlib).

@dstansby
Copy link
Member

Could you perhaps check with codecov why they're not showing up? Not having them easy to access/see just adds more effort on top of the already congested PR queue!

@anntzer
Copy link
ContributorAuthor

sure, will do

- `transformA + transformB.inverted()` === `transformA - transformB`,  and give the result a more meaningful name.- Other cleanups in axislines.py (which used the above pattern quite a  bit).
@anntzer
Copy link
ContributorAuthor

It's here now, it looks like it's just very delayed.

dstansby reacted with thumbs up emoji

@QuLogicQuLogic added this to thev3.2.0 milestoneJul 19, 2019
@QuLogicQuLogic merged commit18bc802 intomatplotlib:masterJul 19, 2019
@anntzeranntzer deleted the inverted branchJuly 19, 2019 09:30
@anntzeranntzer mentioned this pull requestOct 1, 2019
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@dstansby@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp