Movatterモバイル変換

lib/matplotlib/scale.py

		@@ -100,8 +107,8 @@ def set_default_locators_and_formatters(self, axis):

		def get_transform(self):
		"""
		The transform for linear scaling is just the
		:class:`~matplotlib.transforms.IdentityTransform`.
		Return the transform for linear scaling, which is just the

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just inherit all these docstrings? not sure per-scale documentation of get_transform is really useful.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For now, I'd leave it. There's a bit of value to have the link to the respective transform in the subclasses. Alternatively, one could document these relations for the builtin scales in a common place. and eliminate most of theget_transforms. Almost all are just returningself._transform. But that's for another time. You are welcome to make a PR (after this is merged 😉).

anntzer reviewed

lib/matplotlib/scale.py OutdatedShow resolvedHide resolved

anntzer reviewed

lib/matplotlib/scale.py OutdatedShow resolvedHide resolved

anntzer reviewed

lib/matplotlib/scale.py OutdatedShow resolvedHide resolved

timhoffm force-pushed thedoc-scale branch 4 times, most recently froma9875dc tob653f5fCompare

July 16, 2019 18:47

QuLogic reviewed

Jul 18, 2019

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some typos to fix.

lib/matplotlib/scale.py OutdatedShow resolvedHide resolved

lib/matplotlib/transforms.py OutdatedShow resolvedHide resolved

timhoffm force-pushed thedoc-scale branch fromb653f5f to7baf352Compare

July 18, 2019 01:03

timhoffm added the status: needs review label

Jul 21, 2019

anntzer reviewed

lib/matplotlib/scale.pyShow resolvedHide resolved

anntzer approved these changes

Copy link

Contributor

anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one more nitpick, can self-merge after fix

Cleanup of scales docs

9b1a26f

timhoffm force-pushed thedoc-scale branch from7baf352 to9b1a26fCompare

July 22, 2019 21:40

QuLogic merged commit72d6bed intomatplotlib:master

QuLogic removed the status: needs review label

Copy link

lumberbot-appbot commentedJul 22, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v3.1.x$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 72d6bede7d92aa7f3ae6a72e19e2ed3b65f68b69

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #14654: Cleanup of docstrings of scales'

Push to a named branch :

git push YOURFORK v3.1.x:auto-backport-of-pr-14654-on-v3.1.x

Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR#14654 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

lumberbot-appbot added the status: needs manual backport label

timhoffm removed the status: needs manual backport label

Copy link

MemberAuthor

timhoffm commentedJul 22, 2019

Not bothering to backport as 3.2 is approaching.

timhoffm deleted the doc-scale branch

July 22, 2019 23:16

QuLogic modified the milestones:v3.1.2,v3.2.0