NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Second attempt at fixing axis inversion (for mpl3.1).#14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ivanov merged 1 commit intomatplotlib:v3.1.xfromanntzer:moreaxisinversion

Jun 28, 2019

Merged

Second attempt at fixing axis inversion (for mpl3.1).#14643

ivanov merged 1 commit intomatplotlib:v3.1.xfromanntzer:moreaxisinversion

Jun 28, 2019

Conversation

Copy link

Contributor

anntzer commentedJun 28, 2019

Turns out that the behavior of nonsingular() and limit_range_for_scale()
w.r.t. respecting argument order is all over the place, so just re-sort
the axis limits after-the-fact.

Closes#14623 (comment).

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Second attempt at fixing axis inversion (for mpl3.1).

7f7b048

Turns out that the behavior of nonsingular() and limit_range_for_scale()w.r.t. respecting argument order is all over the place, so just re-sortthe axis limits after-the-fact.

anntzer added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label

Jun 28, 2019

anntzer added this to thev3.1.1 milestone

Jun 28, 2019

This was referencedJun 28, 2019

Fix axis inversion with loglocator and logitlocator.#14623

Merged

Fix axis inversion with loglocator and logitlocator.#14624

Merged