Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix axis inversion with loglocator and logitlocator.#14624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:loglocatororder
Aug 20, 2019

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJun 25, 2019•
edited
Loading

PR Summary

Reverts a minor part of#13593 to provide a different fix to#14615 and#14162

I chose to make nonsingular always order its arguments (and thus just change the behavior in the base class, which was only introduced in 3.1, rather than change the behavior of the subclass, which was only introduced in#13593 and not released yet) as that seems more likely to be respected by third-party implementations. On the other hand in#14643 I realized we can't really trust (for now) whether third-party implementations (or our own) do this ordering, so redoing a sort after-the-fact is likely the most robust solution...

The 3.1.x version is at#14623; this PR should not be backported.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.2.0 milestoneJun 25, 2019
@anntzeranntzerforce-pushed theloglocatororder branch 3 times, most recently from177164d toeec8dbaCompareJune 28, 2019 08:08
@anntzeranntzer added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelAug 6, 2019
@anntzer
Copy link
ContributorAuthor

release critical: a similar fix already made it to 3.1 in#14623.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Technically correct. The argument for makingnonsingular order the values sounds reasonable, but I don't have a complete overview of the consequences.

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

modulo CI passing on rebase.

Anyone can merge on clean CI

@tacaswelltacaswell merged commit5e3bede intomatplotlib:masterAug 20, 2019
@anntzeranntzer deleted the loglocatororder branchAugust 20, 2019 14:51
@anntzeranntzer mentioned this pull requestAug 26, 2019
6 tasks
tacaswell added a commit to jb-leger/matplotlib that referenced this pull requestSep 4, 2019
Inmatplotlib#14624 we revertedchanging the order of the limits to match the input order.  Doing thesame here for consistency.
tacaswell added a commit to jb-leger/matplotlib that referenced this pull requestSep 6, 2019
Inmatplotlib#14624 we revertedchanging the order of the limits to match the input order.  Doing thesame here for consistency.Sort the limits before comparing.  We want to make sure that it workswith the values reversed, but do not expect non-singular to preservethe order.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp