NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching.#14592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 1 commit intomatplotlib:masterfromanntzer:secondaryformatter

Feb 25, 2020

Merged

In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching.#14592

jklymak merged 1 commit intomatplotlib:masterfromanntzer:secondaryformatter

Feb 25, 2020

Conversation

Copy link

Contributor

anntzer commentedJun 20, 2019

_set_scale checks whether the parent scale changed before modifying the
secondary scale. set_functions should do the same. See added test for
previously failing case.

(Basically a followup to#14447.)

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer force-pushed thesecondaryformatter branch from650323a to0e1f13bCompare

June 20, 2019 22:36

tacaswell added this to thev3.3.0 milestone

Aug 24, 2019

In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching.

c7f6506

_set_scale checks whether the parent scale changed before modifying thesecondary scale.  set_functions should do the same.  See added test forpreviously failing case.

anntzer force-pushed thesecondaryformatter branch from0e1f13b toc7f6506Compare

February 5, 2020 15:24