Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make logscale bar/hist autolimits more consistents.#14581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
85e814f
to7f80dab
CompareThe bottom limit of log-scaled bar/hist plots now defaults to applyingnormal margins (possibly with null limits expansion) to the data limits,rather than being hardcoded to 1/log_base. See changelog.Delete two tests that asserted that the lower limit was at 1/log_base.
timhoffm approved these changesAug 10, 2019
dstansby approved these changesAug 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
See changelog.
e.g.
This previously gave

This PR makes the all rows always use the "top right/bottom left" behavior. Because hist(histtype="bar") (the default) simply calls bar(), this PR also makes the behavior of hist() more consistent.
The deleted tests arehttps://github.com/matplotlib/matplotlib/blob/v3.1.0/lib/matplotlib/tests/baseline_images/test_axes/hist_steplog.png, which is now

(the lower margin is much more reasonable IMO) and#4608 (now both histograms go to 1e-2 -- one because that's what's passed as bottom, the other one because it goes basically to minus infinity but relies on the other's sticky margin).
Closes#4621 (which is essentially the same as the issue demo'ed above).
Closes#14981.
PR Summary
PR Checklist