Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: don't close figures if switch_backend is a no-op#14471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tacaswell
Copy link
Member

I think this should go in for 3.1.1 as it helps to reduce the
action-at-a-distance issues around the auto-backend / IPython
configuration.

  • Has Pytest style unit tests
  • Code isFlake 8 compliant

anntzer
anntzer previously approved these changesJun 6, 2019
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

modulo#14426 (comment) but heh

@tacaswelltacaswell added this to thev3.2.0 milestoneJun 7, 2019
@tacaswelltacaswellforce-pushed thefix_dont_close_on_noop_switch branch from9bb75fe to02d3c1bCompareAugust 19, 2019 13:43
@tacaswelltacaswellforce-pushed thefix_dont_close_on_noop_switch branch fromb4f9ebb to3eeb476CompareAugust 19, 2019 19:31
dopplershift
dopplershift previously approved these changesAug 19, 2019
Copy link
Contributor

@dopplershiftdopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM assuming CI passes.

@tacaswelltacaswellforce-pushed thefix_dont_close_on_noop_switch branch from30ebdf9 to78ca4cbCompareAugust 24, 2019 18:17
@tacaswelltacaswell modified the milestones:v3.2.0,v3.3.0Aug 24, 2019
@tacaswell
Copy link
MemberAuthor

rebased, but there is something funny going on here, pushed to 3.3.

@tacaswelltacaswellforce-pushed thefix_dont_close_on_noop_switch branch from78ca4cb to5ee99aeCompareJanuary 20, 2020 01:12
@tacaswelltacaswell modified the milestones:v3.3.0,v3.4.0May 11, 2020
@tacaswelltacaswellforce-pushed thefix_dont_close_on_noop_switch branch from5ee99ae toa7e7cf1CompareAugust 24, 2020 02:20
@tacaswelltacaswell dismissed stale reviews fromdopplershift andanntzerAugust 24, 2020 02:20

old

@jklymakjklymak marked this pull request as draftSeptember 10, 2020 15:28
@QuLogicQuLogic modified the milestones:v3.4.0,v3.5.0Jan 21, 2021
@QuLogicQuLogic modified the milestones:v3.5.0,v3.6.0Aug 23, 2021
@timhoffmtimhoffm modified the milestones:v3.6.0,unassignedApr 30, 2022
@tacaswelltacaswell modified the milestones:unassigned,v3.7.0Sep 1, 2022
@tacaswelltacaswellforce-pushed thefix_dont_close_on_noop_switch branch froma7e7cf1 to5ebb5f9CompareSeptember 1, 2022 22:31
@tacaswelltacaswell marked this pull request as ready for reviewSeptember 1, 2022 22:33
@timhoffm
Copy link
Member

Can we have some documentation on the behavior; maybe in theswitch_vackend dockstring?

@timhoffm
Copy link
Member

This took us just 6 releases. 😮

stonebig reacted with hooray emoji

@jklymak
Copy link
Member

@anntzer can you weigh in on this again so Tom doesn't have to rebase any more?

@jklymakjklymak requested a review fromanntzerOctober 23, 2022 20:24
@anntzer
Copy link
Contributor

I'm still not really convinced it's the right approach (per my comment above), also I'd say that if we really want to go that route we should skip closing whenever the event loops are compatible (e.g. going from qtagg to qtcairo), not just when the backends are exactly equal. OTOH we can always decide on that later and I don't feel overly strongly about this.

@anntzeranntzer merged commit68c78c9 intomatplotlib:mainOct 23, 2022
@tacaswelltacaswell deleted the fix_dont_close_on_noop_switch branchOctober 23, 2022 23:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

@dopplershiftdopplershiftdopplershift left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

6 participants
@tacaswell@timhoffm@jklymak@anntzer@dopplershift@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp