Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix out of bounds read in backend_tk.#14461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Really, we should specify somewhere how rounding of bboxes passed toblit() (and to copy_from_bbox()) works, but at least this patch willavoid out-of-bounds reads in the tk blit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
makes sense as a sanitation measure. A little concerned that out-of-bounds stuff can happen, but it is probably benign.
As an extra layer of protection one could raise an error in |
I will follow up with a PR at the c level. |
…461-on-v3.1.xBackport PR#14461 on branch v3.1.x (Fix out of bounds read in backend_tk.)
Really, we should specify somewhere how rounding of bboxes passed to
blit() (and to copy_from_bbox()) works, but at least this patch will
avoid out-of-bounds reads in the tk blit.
@aliaa@cgohlke I think thiscloses#14225, can you confirm?
PR Summary
PR Checklist