Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Assume that mpl-data is in its standard location.#14401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:datapath
Jun 8, 2019

Conversation

anntzer
Copy link
Contributor

The previous candidates tested in get_candidate_paths were for

  1. when matplotlib itself was a namespace package (a long time ago,
    before mpl_toolkits were move out of matplotlib proper), and
  2. py2exe support, which is deprecated (see deprecation of
    get_py2exe_datafiles).

Just to be sure in case someone else is relying on the paths in
get_candidate_paths, emit a deprecation warning in case they are needed,
but let's not bother with an API changes note (it's not even clear how
to word that).

Note that redistributors (e.g. linux distro packagers) who may want to
move mpl-data out can still do so by patching out the entire
_get_data_path function.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The previous candidates tested in get_candidate_paths were for1) when matplotlib itself was a namespace package (a long time ago,   before mpl_toolkits were move out of matplotlib proper), and2) py2exe support, which is deprecated (see deprecation of   get_py2exe_datafiles).Just to be sure in case someone else is relying on the paths inget_candidate_paths, emit a deprecation warning in case they are needed,but let's not bother with an API changes note (it's not even clear howto word that).Note that redistributors (e.g. linux distro packagers) who may want tomove mpl-data out can still do so by patching out the entire`_get_data_path` function.
@anntzeranntzer added this to thev3.2.0 milestoneMay 31, 2019
@tacaswelltacaswell merged commit4f2ee1a intomatplotlib:masterJun 8, 2019
@tacaswell
Copy link
Member

attn@sandrotosi@QuLogic

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@tacaswell@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp