Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove redundant is_landscape kwarg from backend_ps helpers.#14352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesMay 28, 2019
The internale backend_ps _print_figure and _print_figure_tex helpers getpassed both the orientation="portrait"/"landscape" and theis_landscape=True/False kwargs.Remove is_landscape and change orientation to be an enum.Also deprecate dryrun from _print_figure_tex (this should have happenedat the same time as when it was deprecated from _print_figure (it's thesame public API).Also remove unnecessary default parameters from _print_figure (thesearguments are always passed positionally to the helper, and not presentin _print_figure_tex).
At least the dryrun deprecation should go in to 3.2 to match#14134, so I'll label this as release-critical; but if the whole PR can't make it in time I can also split out the deprecation to a separate PR. |
power-cycled because I can not read and did not see the codecov reports. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
backend: psRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The internal backend_ps _print_figure and _print_figure_tex helpers get
passed both the orientation="portrait"/"landscape" and the
is_landscape=True/False kwargs.
Remove is_landscape and change orientation to be an enum.
Also deprecate dryrun from _print_figure_tex (this should have happened
at the same time as when it was deprecated from _print_figure (it's the
same public API).
Also remove unnecessary default parameters from _print_figure (these
arguments are always passed positionally to the helper, and not present
in _print_figure_tex).
PR Summary
PR Checklist