NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.2k

Remove check_requirements from setupext.#14172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 1 commit intomatplotlib:masterfromanntzer:check_requirements

May 9, 2019

Merged

Remove check_requirements from setupext.#14172

timhoffm merged 1 commit intomatplotlib:masterfromanntzer:check_requirements

May 9, 2019

Conversation

Copy link

Contributor

anntzer commentedMay 8, 2019

We can just use boring old inheritance of check() (check_requirements()
never returns relevant information on success anyways -- the OS returned
by BackendMacOSX.check_requirements() is already displayed through
Platform.check()).

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Remove check_requirements from setupext.

aceddbf

We can just use boring old inheritance of check() (check_requirements()never returns relevant information on success anyways -- the OS returnedby BackendMacOSX.check_requirements() is already displayed throughPlatform.check()).

anntzer added the Build label

May 8, 2019