Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
In setup.py, inline the packages that need to be installed into setup().#14170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Deleted my comment because I failed to read before I typed. Given the discussion we had with the Arch packagers in#13993 is this going to cause the same problem? Having clean data-only wheels for the test data does seem like a good carrot. |
We can ping@ArchangeGabriel here to ask :) This time it is definitely intentional to always install the test source files, just leaving the baseline images optional; I think if downstream packagers want to also remove the tests they can just yank them out a posteriori. |
It’s fine, we can indeed just remove the test files afterwards if they are not spread over hundreds of directories. ;) Also since we don’t pass the baseline images comparisons (because of different freetype), this change could actually leads to simplification of our building scripts if testing skip baseline images tests when they are missing. |
anntzer commentedMay 12, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You can just |
Ignoring the image tests would be awesome because it means we would actually be able to automatically and easily verify no other tests failed. :) |
Uh oh!
There was an error while loading.Please reload this page.
... instead of hiding that behind a function call in setupext.Also always install the test source files -- setting `tests = False` insetup.cfg now only ignores the test data (this is also consistent withthe contents of `matplotlib/tests/__init__.py which is clearly intendedto handle the case where the test source files are installed but not thebaseline images). This is done for simplicity of implementation andalso to make it possibly easier to separately install the baselineimages (as these are now pure "data") in the future.
I think thatthis part of setup.cfg should have been updated to say that what is controlled here is only about data, not actually packages (tests being installed anyway now). What is your opinion on this? |
Sounds fair, do you want to open a PR for that? |
Also, currently having |
yes |
OK, made some attempt at#15480. |
... instead of hiding that behind a function call in setupext.
(See also#13542 which does the same with {install,setup}_requires.)
Also always install the test source files -- setting
tests = Falseinsetup.cfg now only ignores the test data (this is also consistent with
the contents of `matplotlib/tests/init.py which is clearly intended
to handle the case where the test source files are installed but not the
baseline images). This is done for simplicity of implementation and
also to make it possibly easier to separately install the baseline
images (as these are now pure "data") in the future (WIP in#11732).
PR Summary
PR Checklist