Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix regexp for dvipng version detection#14164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

timhoffm
Copy link
Member

PR Summary

dvipng --verision outputs in some recent version

This is dvipng 1.15 Copyright 2002-2015 Jan-Ake Larssondvipng 1.15kpathsea version 6.2.3Compiled with Freetype 2.8.1Using libft 2.8.1Copyright (C) 2002-2015 Jan-Ake Larsson.There is NO warranty.  You may redistribute this softwareunder the terms of the GNU Lesser General Public Licenseversion 3, see the COPYING file in the dvipng distributionor <http://www.gnu.org/licenses/>.

This was not captured by the regexp. It probably assumeddvipng version 1.15 or similar. The changed regexp still accepts all the previous strings plus one with only a single space betweendvipng and the version number.

This bug made@needs_usetex skip tests, claiming a missing TeX installation. Noticed from#14156.

@anntzer
Copy link
Contributor

Indeed, locally I have

This is dvipng (dvipng (TeX Live)) 1.15 Copyright 2002-2015 Jan-Ake Larssondvipng (dvipng (TeX Live)) 1.15kpathsea version 6.3.0Compiled with Freetype 2.9.0Using libft 2.9.0Copyright (C) 2002-2015 Jan-Ake Larsson.There is NO warranty.  You may redistribute this softwareunder the terms of the GNU Lesser General Public Licenseversion 3, see the COPYING file in the dvipng distributionor <http://www.gnu.org/licenses/>.

but your fix looks good.

@timhoffmtimhoffmforce-pushed thefix-dvipng-version-regexp branch fromc1db023 to4859562CompareMay 7, 2019 22:26
@jklymakjklymak merged commit778f4da intomatplotlib:masterMay 12, 2019
@timhoffmtimhoffm deleted the fix-dvipng-version-regexp branchMay 12, 2019 08:43
@QuLogicQuLogic added this to thev3.2.0 milestoneMay 13, 2019
@tacaswell
Copy link
Member

This should probably be backported to 3.1.1 (found this while doing the 3.1.x -> master merge after tagging 3.1.0 :/)

@meeseeksdev backport to v3.1.x

@tacaswelltacaswell modified the milestones:v3.2.0,v3.1.1May 18, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 18, 2019
timhoffm added a commit that referenced this pull requestMay 18, 2019
…164-on-v3.1.xBackport PR#14164 on branch v3.1.x (Fix regexp for dvipng version detection)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

5 participants
@timhoffm@anntzer@tacaswell@jklymak@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp