Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix deprecation of withdash for figtext().#14150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Apply the same check for _deprecated_parameter in Figure.text() (akaplt.figtext()) as in Axes.text().Otherwise any call to Figure.text(), even without passing withdash,emits a deprecation warning (because _deprecated_parameter is truthy).
dstansby approved these changesMay 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 if/when CI passes
timhoffm approved these changesMay 7, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 7, 2019
timhoffm added a commit that referenced this pull requestMay 7, 2019
…150-on-v3.1.xBackport PR#14150 on branch v3.1.x (Fix deprecation of withdash for figtext().)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the same check for _deprecated_parameter in Figure.text() (aka
plt.figtext()) as in Axes.text(); xref
matplotlib/lib/matplotlib/axes/_axes.py
Line 777 inf620c0e
Otherwise any call to Figure.text(), even without passing withdash,
emits a deprecation warning (because _deprecated_parameter is truthy).
PR Summary
PR Checklist