Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Make test suite fail on warnings.#14131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
0cd9194 to59a0ce2Comparetacaswell approved these changesMay 6, 2019
jklymak approved these changesMay 6, 2019
6 tasks
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestAug 11, 2019
The issue is thatmatplotlib#14131made our test suite fail on any warnings (good!), however we do nottest all versions of numpy and `np.min([np.nan])` seems to warn for1.14.4 < version < 1.15.0 which is not a range we test on travis.However, the version of numpy that the wheels pin to for py37 in1.14.6 which does warn.This is likely related tonumpy/numpy#10370
6 tasks
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestAug 12, 2019
The issue is thatmatplotlib#14131made our test suite fail on any warnings (good!), however we do nottest all versions of numpy and `np.min([np.nan])` seems to warn for1.14.4 < version < 1.15.0 which is not a range we test on travis.However, the version of numpy that the wheels pin to for py37 in1.14.6 which does warn.This is likely related tonumpy/numpy#10370
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
There are a few remaining warnings with secondary_axes, which should be handled by#13593 (which, as a side effect, delays applyings margins to the secondary axes until the axes have "valid" limits).
Edits:
PR Checklist