Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make test suite fail on warnings.#14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromanntzer:werror
May 6, 2019
Merged

Conversation

@anntzer
Copy link
Contributor

@anntzeranntzer commentedMay 4, 2019
edited
Loading

PR Summary

There are a few remaining warnings with secondary_axes, which should be handled by#13593 (which, as a side effect, delays applyings margins to the secondary axes until the axes have "valid" limits).

Edits:

  • Looks like test_warn_external_frame_embedded_python had to be slightly adjusted (although it does something nasty by patching sys, so it probably can't really be considered a pytest bug...); done.
  • And some warning with old numpys, also fixed.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzerforce-pushed thewerror branch 2 times, most recently from0cd9194 to59a0ce2CompareMay 5, 2019 10:44
@tacaswelltacaswell added this to thev3.2.0 milestoneMay 6, 2019
@jklymakjklymak merged commit8b05b35 intomatplotlib:masterMay 6, 2019
@anntzeranntzer deleted the werror branchMay 6, 2019 19:31
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestAug 11, 2019
The issue is thatmatplotlib#14131made our test suite fail on any warnings (good!), however we do nottest all versions of numpy and `np.min([np.nan])` seems to warn for1.14.4 < version < 1.15.0 which is not a range we test on travis.However, the version of numpy that the wheels pin to for py37 in1.14.6 which does warn.This is likely related tonumpy/numpy#10370
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestAug 12, 2019
The issue is thatmatplotlib#14131made our test suite fail on any warnings (good!), however we do nottest all versions of numpy and `np.min([np.nan])` seems to warn for1.14.4 < version < 1.15.0 which is not a range we test on travis.However, the version of numpy that the wheels pin to for py37 in1.14.6 which does warn.This is likely related tonumpy/numpy#10370
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer@tacaswell@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp