Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove font preamble caching in TexManager.#14044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:texmancache
Mar 23, 2020

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedApr 25, 2019
edited
Loading

TexManager has a complex caching machinery (... among other caching
layers) to map font-related rcParams to a tex preamble (see_rc_cache,
_rc_cache_keys,_reinit) but that's just a matter of a few dict
lookups which are negligible compared to invoking the subprocess; so
just strip out that caching and always regenerate the font-related
preamble.

That caching also set some attributes (texmanager.serif, etc.) as a
side-effect viasetattr/getattr, which are used nowhere else (and
it's hard to know they even exist other than figuring out the relevant
setattr calls); just deprecate them.

(I have some followup cleanups on that...)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

TexManager has a complex caching machinery (... among other cachinglayers) to map font-related rcParams to a tex preamble (see `_rc_cache`,`_rc_cache_keys`, `_reinit`) but that's just a matter of a few dictlookups which are negligible compared to invoking the subprocess; sojust strip out that caching and always regenerate the font-relatedpreamble.That caching also set some attributes (`texmanager.serif`, etc.) as aside-effect via `setattr`/`getattr`, which are used nowhere else (andit's hard to know they even exist other than figuring out the relevant`setattr` calls); just deprecate them.
@anntzer
Copy link
ContributorAuthor

rebased

@timhoffmtimhoffm added this to thev3.3.0 milestoneMar 23, 2020
@timhoffmtimhoffm merged commit65ebc8c intomatplotlib:masterMar 23, 2020
@anntzeranntzer deleted the texmancache branchMarch 23, 2020 08:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp