NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Add support for metadata= and pil_kwargs= in imsave().#13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dstansby merged 1 commit intomatplotlib:masterfromanntzer:imsavemetadatapilkwargs

May 6, 2019

Merged

Add support for metadata= and pil_kwargs= in imsave().#13902

dstansby merged 1 commit intomatplotlib:masterfromanntzer:imsavemetadatapilkwargs

May 6, 2019

Conversation

Copy link

Contributor

anntzer commentedApr 7, 2019

For consistency with savefig().

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link

ContributorAuthor

anntzer commentedApr 7, 2019

Not really sure where the test failure comes from, I wonderif it is exposing an issue with multiprocessing...

anntzer added the status: work in progress label

Apr 7, 2019

tacaswell added this to thev3.2.0 milestone

Apr 11, 2019

Copy link

Member

tacaswell commentedApr 11, 2019

"crashed" sounds like segfault not an exception. Nothing jump out at me either....

Copy link

Member

QuLogic commentedApr 11, 2019

The problem is that the original path replacesNone with an empty dictionary (+ theSoftware key), but this new one doesn't. The C code doesn't expect or handleNone, or even non-dictionary types.