Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate original NavigationToolbar#1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The alternative is deprecating each of the backend's NavigationToolbar classes (there is no superclass to do it in just one place). Based on this information, I agree with your approach of deprecating it for the majority of users (those who don't use pyplot to setup their figures won't necessarily get this message). Is there an appropriate place to document this change? Perhaps the api_changes document? The implementation looks good to me. +1 |
I also agree with the implementation here. |
This looks good to me. Deprecating the classes as@pelson suggests would also be fine, but I think the vast majority of users are probably choosing it through the rcParam, which this PR currently addresses. |
Deprecate original NavigationToolbar
There seemed to be agreement on the mailing list that we could deprecate the original NavigationToolbar in the 1.2 release. In this PR I have done the most minimal version of deprecation, that is, putting a warning in the rcParams validator.