Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Switch deprecation of Tick.label to pending.#13631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This should give more time to seaborn to update itself. (Pendingdeprecations are not displayed by default, but are enabled e.g. bypytest.)
QuLogic approved these changesMar 8, 2019
jklymak approved these changesMar 8, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 8, 2019
jklymak added a commit that referenced this pull requestMar 8, 2019
…631-on-v3.1.xBackport PR#13631 on branch v3.1.x (Swicth deprecation of Tick.label to pending.)
Thanks@anntzer ! |
tacaswell added a commit to tacaswell/seaborn that referenced this pull requestMar 9, 2019
The Tick.label property will be deprecated and begin warning in afuture version of Matplotlib. Explicitly using the correct propertywill avoid this.Seematplotlib/matplotlib#10088 andmatplotlib/matplotlib#13631
I opened a PR against seaborn to fix it on their side as well. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should give more time to seaborn to update itself. (Pending
deprecations are not displayed by default, but are enabled e.g. by
pytest.)
Closes#13623. (I am totally fine with going slow with the deprecation, but do not believe that just because seaborn currently uses the API, we cannever ever change it.)
PR Summary
PR Checklist