Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Move {setup,install}_requires from setupext.py to setup.py.#13542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The Numpy class in setupext.py serves two purposes: declare asetup_requires and an install_requires on numpy, and provide aadd_flags() (effectively static) method to link extension modules tonumpy.Instead, we can just merge the setup and install_requires togetherwith all other install_requires, and move all of them to setup.py(deleting the machinery to grab setup_requires and install_requiresfrom multiple places), and make the add_flags() method a free function(add_numpy_flags()).
6 tasks
efiring approved these changesMay 26, 2019
Member
efiring left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not a setup expert by any means, but this looks good to me.
timhoffm approved these changesMay 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Numpy class in setupext.py serves two purposes: declare a
setup_requires and an install_requires on numpy, and provide a
add_flags() (effectively static) method to link extension modules to
numpy.
Instead, we can just merge the setup and install_requires together
with all other install_requires, and move all of them to setup.py
(deleting the machinery to grab setup_requires and install_requires
from multiple places), and make the add_flags() method a free function
(add_numpy_flags()).
PR Summary
PR Checklist