NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Deprecate backend_wx.IDLE_DELAY.#13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 1 commit intomatplotlib:masterfromanntzer:IDLE_DELAY

Feb 21, 2019

Merged

Deprecate backend_wx.IDLE_DELAY.#13473

timhoffm merged 1 commit intomatplotlib:masterfromanntzer:IDLE_DELAY

Feb 21, 2019

Conversation

Copy link

Contributor

anntzer commentedFeb 20, 2019

per changelog.

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Deprecate backend_wx.IDLE_DELAY.

b8e1a01

per changelog.

anntzer added the GUI: wx label

Feb 20, 2019

anntzer added this to thev3.1.0 milestone

Feb 20, 2019

Copy link

Contributor

dopplershift commentedFeb 20, 2019

I think when we support python >=3.7, we’ll have the hooks necessary to actually warn about this.

Copy link

ContributorAuthor

anntzer commentedFeb 20, 2019•
edited
Loading

It's actually not much harder to emit a warning on Py3.6 (#10735); actually I don't like the module-level__getattr__ addtion in Py3.7 at all :/ as the tools to do that were already present, and the module-level__getattr__ introduces a weird exception to the rule that dunders are looked up on the class (here that would be ModuleType), not on the instance (the module itself).