Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: polar set_rlim allow bottom-only call#13465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 2 commits intomatplotlib:masterfromjklymak:fix-polar-bottom
Feb 23, 2019

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedFeb 18, 2019•
edited
Loading

PR Summary

closes#13464

Not sure this is the canonical way to do this. Improvements welcome.

Should obviously get a test so this doesn't get missed again.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymak changed the titleFIX: allow bottom-only callFIX: pooler set_rlim allow bottom-only callFeb 19, 2019
@jklymakjklymak changed the titleFIX: pooler set_rlim allow bottom-only callFIX: polar set_rlim allow bottom-only callFeb 19, 2019
@jklymakjklymak added topic: polar Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelsFeb 19, 2019
@jklymakjklymak added this to thev3.1.0 milestoneFeb 19, 2019
if top is None and len(bottom) == 2:
top = bottom[1]
bottom = bottom[0]
if top is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

set_xlim uses

        if right is None and np.iterable(left):            left, right = left

I think it's reasonable to use the same pattern here.

Note: This will explicitly failset_rlim((1, 2, 3)). Your code would let that pass, and I assume it would have failed later on, since the assumption from here on is that bottom is a scalar.

anntzer reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done!

@jklymak
Copy link
MemberAuthor

@QuLogic I think you recently did heavy polar work. Is this fix OK?

@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

timhoffm added a commit that referenced this pull requestFeb 23, 2019
…465-on-v3.1.xBackport PR#13465 on branch v3.1.x (FIX: polar set_rlim allow bottom-only call)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

@QuLogicQuLogicAwaiting requested review from QuLogic

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.topic: polar
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

set_rlim(bottom=...) no longer works
3 participants
@jklymak@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp