Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BLD: only try to get freetype src if src does not exist#13455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Third time's the charm? |
| tgz.extractall("build") | ||
| # do we need to download / load the source from cache? | ||
| if not os.path.exists(src_path): | ||
| if not os.path.exists('build'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this belongs out of the main if? (if the source tree exists but not the buildddir, you still want to mkdir build)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The src path is inbuild (see L954) so if we have the source dir,build exists.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
…oad_logicBLD: only try to get freetype src if src does not exist
…455-on-v3.0.xBackport PR#13455 on branch v3.0.x (BLD: only try to get freetype src if src does not exist)
…-v2.2.xMerge pull request#13455 from tacaswell/fix_freetype_download_logic
Closes#13450 (again)
PR Summary
PR Checklist