Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: add additional qt5 deb package on travis#13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromtacaswell:qt512_fix
Feb 11, 2019

Conversation

tacaswell
Copy link
Member

@tacaswelltacaswell commentedFeb 11, 2019•
edited by QuLogic
Loading

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems to work!

@dstansbydstansby added this to thev3.1.0 milestoneFeb 11, 2019
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure if this ha to be backported, so I've just left it in 3.1.0

@dstansbydstansby merged commit121102b intomatplotlib:masterFeb 11, 2019
@tacaswelltacaswell deleted the qt512_fix branchFebruary 11, 2019 21:45
@QuLogic
Copy link
Member

@meeseeksdev backport to v3.0.x

See#13416.

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 121102b972d40aa069a7d71ba02e5b447407de39
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #13412: CI: add additional qt5 deb package on travis'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-13412-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR#13412 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@tacaswell
Copy link
MemberAuthor

For the record I did this based on a comment@smheidrich at#13404 (comment) that I completely failed to credit 😞

QuLogic added a commit that referenced this pull requestFeb 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

4 participants
@tacaswell@QuLogic@jklymak@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp