NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Deemphasize numeric locations for legend() in docs.#13411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ImportanceOfBeingErnest merged 1 commit intomatplotlib:masterfromanntzer:legendnumeric

Feb 14, 2019

Merged

Deemphasize numeric locations for legend() in docs.#13411

ImportanceOfBeingErnest merged 1 commit intomatplotlib:masterfromanntzer:legendnumeric

Feb 14, 2019

Conversation

Copy link

Contributor

anntzer commentedFeb 11, 2019

... as well as the "right" synonym to "center right".

(Note that despite the mention of backcompat, I am not proposing a
deprecation here.)

Per#11127 (comment), which I agree with.

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Deemphasize numeric locations for legend() in docs.

1553307

... as well as the "right" synonym to "center right".(Note that despite the mention of backcompat, I am not proposing adeprecation here.)

anntzer added the Documentation label

Feb 11, 2019

anntzer commented

Feb 11, 2019

View reviewed changes

lib/matplotlib/legend.py

		The location of the legend.

		The strings
		``'upper left', 'upper right', 'lower left', 'lower right'``

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know that strings don't usually get double-backquoted in the docs, but I did so on purpose here as it seems better to add a bit of emphasis to the list of valid values. (The linebreaks are for the same reason.)