NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Revert "Add inaxes method to FigureCanvas to check whether point is in an axes."#13404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

jklymak wants to merge1 commit intomasterfromrevert-9845-inaxes

Closed

Revert "Add inaxes method to FigureCanvas to check whether point is in an axes."#13404

jklymak wants to merge1 commit intomasterfromrevert-9845-inaxes

Conversation

Copy link

Member

jklymak commentedFeb 11, 2019

Reverts#9845 This broke the build, and needs to be re-facotered to work with 3.0.1

Revert "Add inaxes method to FigureCanvas to check whether point is i…

050a6b4

…n an axes."

jklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label

Feb 11, 2019

jklymak added this to thev3.1.0 milestone

Feb 11, 2019

Copy link

MemberAuthor

jklymak commentedFeb 11, 2019

Huh, that didn't fully fix it either There was another PR that maybe caused this, or maybe something is wrong w/. CI

Copy link

Contributor

lkjell commentedFeb 11, 2019

@jklymak have to tried to test it locally? I do not get any qt error as in travis on master. However, I had to change windows manager else test_dpi_ratio_change would fail.

Copy link

Member

tacaswell commentedFeb 11, 2019

This looks like a qt configuration error on travis to me...

Copy link

MemberAuthor

jklymak commentedFeb 11, 2019

Yep agreed. Thanks. This pr still needs modificTion but not to be reverted. It was worth a try...

jklymak closed this

Feb 11, 2019

QuLogic deleted the revert-9845-inaxes branch

February 11, 2019 04:51

tacaswell removed the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label

Feb 11, 2019

tacaswell removed this from thev3.1.0 milestone

Feb 11, 2019

Copy link

Contributor

smheidrich commentedFeb 11, 2019

Addingqtbase5-dev as a package to be installed in.travis.ymland deleting the cache on Travis (didn't work without deleting it!)seems to have fixed it for me. But it was pure guesswork and maybe this could be solved by installing only a subset ofqtbase5-dev's dependencies.