Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: remove idle_event#13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 1 commit intomatplotlib:masterfromjklymak:fix-IdleEvent
Feb 11, 2019
Merged

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedFeb 11, 2019•
edited
Loading

PR Summary

OK, so I screwed up merging#9845 because it called a deprecated method. I guess we ned to make sure PRs run on modern tests if they are so old. My apologies.

Anyways, this PR removes the deprecated method.

NOTE: this unbreaks CI...

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymak added this to thev3.1.0 milestoneFeb 11, 2019
@jklymakjklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelFeb 11, 2019
@jklymakjklymak deleted the fix-IdleEvent branchFebruary 11, 2019 00:56
@lkjell
Copy link
Contributor

This still valid PR@jklymak ?

@jklymakjklymak restored the fix-IdleEvent branchFebruary 11, 2019 04:57
@jklymakjklymak reopened thisFeb 11, 2019
@jklymak
Copy link
MemberAuthor

@lkjell Yes, we need to do this because we removedIdleEvent....

@anntzer
Copy link
Contributor

CI still broken with qt, but this is a first step...

@anntzeranntzer merged commitd31d102 intomatplotlib:masterFeb 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@lkjelllkjelllkjell approved these changes

Assignees
No one assigned
Labels
BuildRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

4 participants
@jklymak@lkjell@anntzer@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp