Feb 19, 2019 · Feb 10, 2019 · Feb 10, 2019 · Feb 10, 2019 · Feb 10, 2019 · Feb 10, 2019
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
        elif len(positions) != N:
            raise ValueError(datashape_message.format("positions"))

        positions = np.array(positions)
        if len(positions) > 0 and not isinstance(positions[0], Number):
            raise TypeError("positions should be an iterable of numbers")

        # width
        if widths is None:
            widths = [np.clip(0.15 * np.ptp(positions), 0.15, 0.5)] * N
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
                   (10, 20))


 def test_boxplot_dates_pandas(pd):
    # smoke test for boxplot and dates in pandas
    data = np.random.rand(5, 2)
    years = pd.date_range('1/1/2000',
                          periods=2, freq=pd.DateOffset(years=1)).year
    plt.figure()
    plt.boxplot(data, positions=years)


 def test_bar_pandas(pd):
    # Smoke test for pandas
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3926,6 +3926,10 @@ def dopatch(xs, ys, **kwargs):
		elif len(positions) != N:
		raise ValueError(datashape_message.format("positions"))

		positions = np.array(positions)
Copy link Member NelleVFeb 10, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This is a good fix for the case described in the ticket, but I think the code will continue raising obscure error when positions are not numbers. Can you add a check after this line about the dtype of the array being a number? Maybe something like: ifnotisinstance(positions.dtype,numbers.Number):raiseTypeError("positions should be a iterable of dtype number, but found dtype %s"%blahblahblah.) When we end up supporting something else than numbers, this can be updated. Copy link MemberAuthor jklymakFeb 10, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I couldn't quite get that check to work; I had to check the first element. But if there is a better way, let me know.
		if len(positions) > 0 and not isinstance(positions[0], Number):
		raise TypeError("positions should be an iterable of numbers")

		# width
		if widths is None:
		widths = [np.clip(0.15 * np.ptp(positions), 0.15, 0.5)] * N
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1524,6 +1524,15 @@ def test_bar_timedelta():
		(10, 20))


		def test_boxplot_dates_pandas(pd):
		# smoke test for boxplot and dates in pandas
		data = np.random.rand(5, 2)
		years = pd.date_range('1/1/2000',
		periods=2, freq=pd.DateOffset(years=1)).year
		plt.figure()
		plt.boxplot(data, positions=years)


		def test_bar_pandas(pd):
		# Smoke test for pandas

Expand Down