Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Numpyfy tick handling code in Axis3D.#13364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good and seems to reduce complexity significantly. Just want to make sure the setters that got modified are going to broadcast properly.
| self.gridlines.set_segments(lines) | ||
| self.gridlines.set_color(info['grid']['color']) | ||
| self.gridlines.set_linewidth(info['grid']['linewidth']) | ||
| self.gridlines.set_linestyle(info['grid']['linestyle']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
do we know if these setters are properly broadcasting the scalars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
At least manually setting a scalar into any of these works.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Depends on#13363 (now merged).
PR Checklist