Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bump to flake8 3.7.#13337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:flake837
Feb 1, 2019
Merged

Bump to flake8 3.7.#13337

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:flake837
Feb 1, 2019

Conversation

anntzer
Copy link
Contributor

flake8 3.7 seems to be working fine now.

The associated bump to pycodestyle 2.5 caught a few more style nits.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The associated bump to pycodestyle 2.5 caught a few more style nits.
@dopplershift
Copy link
Contributor

Is there any reason that this change should be affecting what tests we're running? Codecov.io is showing a lot of changes, and it doesn't look spurious.

@tacaswell
Copy link
Member

It looks like appveyor did not fire, maybe this is the coverage we get only from appveyor?

@tacaswelltacaswell added this to thev3.1 milestoneFeb 1, 2019
@timhoffm
Copy link
Member

Might be that we need to take care of flake8 also in the other branches (e.g. it's failing in this backport#13340).

@tacaswelltacaswell merged commit68e8d95 intomatplotlib:masterFeb 1, 2019
@anntzeranntzer deleted the flake837 branchFebruary 1, 2019 14:38
@tacaswell
Copy link
Member

@meeseeksbot backport to v3.0.x

@QuLogic
Copy link
Member

@meeseeksdev backport to v3.0.x

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 68e8d9543abce31da04a79970fdfb5dea914a540
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #13337: Bump to flake8 3.7.'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-13337-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR#13337 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@QuLogic
Copy link
Member

OK, I'll put it in#13418.

@tacaswell
Copy link
Member

Thanks@QuLogic !

@QuLogicQuLogic modified the milestones:v3.1.0,v3.0.3Feb 12, 2019
QuLogic added a commit that referenced this pull requestFeb 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

5 participants
@anntzer@dopplershift@tacaswell@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp