Note that xaxis_inverted is now implemented in terms of get_inverted and
invert_xaxis in terms of set_inverted, so the new methods are properly
tested.

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added the status: work in progress label

Jan 31, 2019

anntzer force-pushed thegetsetinverted branch from3c5be68 to613a64bCompare

January 31, 2019 17:46

Add Axis.get_inverted and Axis.set_inverted.

01aedbc

See rationale in changelog note (basically, Axes.invert_xaxis is finefor interactive use, but a bit of a pain for library-work).Note that xaxis_inverted is now implemented in terms of get_inverted andinvert_xaxis in terms of set_inverted, so the new methods are properlytested.

anntzer force-pushed thegetsetinverted branch from613a64b to01aedbcCompare

January 31, 2019 18:06

anntzer removed the status: work in progress label

Jan 31, 2019

tacaswell added this to thev3.1 milestone

Feb 1, 2019

tacaswell approved these changes

Feb 1, 2019

View reviewed changes

anntzer mentioned this pull request

Feb 1, 2019

pcolorimage/pcolorfast silently drops alpha#13328

Open

jklymak requested changes

Feb 1, 2019

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm concerned about where we are storing the state of the axis. This moves more state intoAxis, but the real home isAxes; the Axis is a slave of that takes care of implimenting the state of the Axes, and indeed all thatAxis.get_view_interval() does is querryAxes.viewLim.intervalx. So I'm against setting the view interval here (though that already exists) and I'm against setting whether that interval is inverted or not here. I think this should all be done at the Axes level...

Copy link

ContributorAuthor

anntzer commentedFeb 1, 2019

The Axis and Axes classes are obviously tightly coupled, but in my view, methods that logically act on a single Axis should, actually, be implemented as Axis methods, not as pairs of Axes methods. If it was up to me, we'd haveax.xaxis.set_lim() andax.yaxis.set_lim(), notax.set_xlim andax.set_ylim (because this avoids having to further addax.set_rlim,ax.set_thetalim for polar axes,ax.set_zlim for 3d axes, etc.; even though they are just trivial wrappers). (Obviously the ship has sailed for set_lim.)