Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
numpydocify Sankey.add.#13217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
numpydocify Sankey.add.#13217
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/matplotlib/sankey.py Outdated
| ---------- | ||
| patchlabel : str | ||
| Label to be placed at the center of the diagram. | ||
| Note that *label* (not *patchlabel*) will be passed to the patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Simpler: Note that label (not patchlabel) can be passed as kwarg to create an entry in the legend.
lib/matplotlib/sankey.py Outdated
| outputs are negative. | ||
| The flows are placed along the top of the diagram from the inside | ||
| out in order of their index within the *flows* list or array. They |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Simpler: ...within flows.
lib/matplotlib/sankey.py Outdated
| shown, regardless of the value of this argument. | ||
| trunklength : float | ||
| Length between the bases of the input and output groups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you give a unit?
Thanks, all comments handled. |
Uh oh!
There was an error while loading.Please reload this page.
Note that the previously stated default facecolor and linewidth onlyapply in _internal.classic_mode, so don't need to be mentioned.
Good to merge? :) |
Oh, yes. I‘m always thinking of two reviews. But this is just documentation, for which one review is sufficient. |
Note that the previously stated default facecolor and linewidth only
apply in _internal.classic_mode, so don't need to be mentioned.
PR Summary
PR Checklist