Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Backport #13205 on branch v3.0.x (Add xvfb service to travis)#13216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 3 commits intomatplotlib:v3.0.xfromNelleV:travis_failures_v30x
Jan 19, 2019

Conversation

NelleV
Copy link
Member

@NelleVNelleV commentedJan 18, 2019
edited
Loading

PR Summary

Attempt to fix some of our Travis failures on v3.0.x. Supersedes#13206
MarkInfo objects were removed in pytest 4.0. The other solution would be to backport the PR that fixes this from our master branch.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@NelleVNelleV changed the titleFIX Starting xvfb as a service to avoid travis failuresBackport #13205 on branch v3.0.x (Add xvfb service to travis)Jan 18, 2019
@tacaswell
Copy link
Member

Restarted 3.5 which was the only one that failed and it failed on the Qt tests. I wonder if there is some roll-over going on where we are getting a mixed population of workers, some the new way works and some the oldway works?

@dstansby
Copy link
Member

Yeah, the 3.5 build is getting axvfb: unrecognized service (https://travis-ci.org/matplotlib/matplotlib/jobs/481215980#L1323)

@tacaswell
Copy link
Member

It is because we force the dist back to trusty, lets see what happens if we drop that....

This is to make sure we have the xvfb as a service
@NelleV
Copy link
MemberAuthor

fui! Great! Thanks a lot for fixing that last problem.

@timhoffmtimhoffm merged commit4a63ccb intomatplotlib:v3.0.xJan 19, 2019
@timhoffm
Copy link
Member

Hm, maybe I should not have squashed the commits. Should I revert and merge without squashing?

@NelleV
Copy link
MemberAuthor

NelleV commentedJan 19, 2019 via email

No, it's good!
On Sat, Jan 19, 2019, 7:30 PM Tim Hoffmann ***@***.*** wrote: Hm, maybe I should not have squashed the commits. Should I revert and merge without squashing? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13216 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALR3uTlBGk9gxbqGJ3dAX87GXTf2geYks5vEte_gaJpZM4aHOSy> .

@NelleV
Copy link
MemberAuthor

NelleV commentedJan 19, 2019 via email

Thanks!On Sat, Jan 19, 2019, 7:36 PM Nelle Varoquaux <nelle.varoquaux@gmail.comwrote:
No, it's good! On Sat, Jan 19, 2019, 7:30 PM Tim Hoffmann ***@***.*** wrote:> Hm, maybe I should not have squashed the commits. Should I revert and> merge without squashing?>> —> You are receiving this because you authored the thread.> Reply to this email directly, view it on GitHub> <#13216 (comment)>,> or mute the thread> <https://github.com/notifications/unsubscribe-auth/AALR3uTlBGk9gxbqGJ3dAX87GXTf2geYks5vEte_gaJpZM4aHOSy>> .>

@QuLogic
Copy link
Member

Most of our backports are squashed anyway (all automated ones are.)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.

5 participants
@NelleV@tacaswell@dstansby@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp