Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Reformat Sankey exceptions.#13214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesJan 18, 2019
I think the first few exceptions that check arguments should explicitly name the arguments, as the descriptions seem a bit inconsistent with |
The indentation of exceptions in the sankey module was a bit peculiar.Reformat them, and reword them to 1) suppress the final dot,consistently with the rest of the library and the stdlib; and 2) removereferences to indices being zero-based (if you think indices are1-based, you probably have started running into issues before learningto use Sankey...).
Good catch, edited accordingly. |
QuLogic approved these changesJan 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indentation of exceptions in the sankey module was a bit peculiar.
Reformat them, and reword them to 1) suppress the final dot,
consistently with the rest of the library and the stdlib; and 2) remove
references to indices being zero-based (if you think indices are
1-based, you probably have started running into issues before learning
to use Sankey...).
The one error reformatted in#13213 is not handled here :)
PR Summary
PR Checklist