Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Broadcast 'orientations' arg to Sankey.add.#13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:sankey
Jan 19, 2019

Conversation

anntzer
Copy link
Contributor

PR Summary

Closes the issue reported by the OP in#13184, but not#13184 (comment).

I know there's no tests, and am not volunteering to write them. (But you can manually check that this fixes the OP's issues.)

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer mentioned this pull requestJan 17, 2019
6 tasks
@anntzer
Copy link
ContributorAuthor

both comments handled, thanks for the review.

@anntzer
Copy link
ContributorAuthor

Actually I removed the change to the docstring (and edited the commit message accordingly) in favor of doing that change in#13217.

@anntzeranntzer changed the titleBroadcast 'orientations' arg to Sankey.add and fix its doc.Broadcast 'orientations' arg to Sankey.add.Jan 18, 2019
@QuLogicQuLogic added this to thev3.1 milestoneJan 19, 2019
@QuLogicQuLogic merged commit0dac001 intomatplotlib:masterJan 19, 2019
@anntzeranntzer deleted the sankey branchJanuary 19, 2019 00:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp