appveyor CI fails because ofpytest-rerunfailures 6.0. I guess this is a missing constraints upadte ind7e3789 (travis was changed but not appveyor). Should I add it here? And then revert in the follow-up PR?

Travis CIs fail withsh: 0: Can't open /etc/init.d/xvfb, not sure if related.

My concern about bumping the pytest version requirement on the 2.2.x branch is that we are going to be caught in this trap where either the slower distributions will not have a new enough version of pytest or the faster distributions will not have an old enough version (pytest 3.6 is only from May 2018).

Could you do all of the backporting / reverting in this PR? I think that makes more sense than a series of PRs.

Sure, I’ll push the revert in a second commit.

Are you aware of distributions still updating matplotlib (even if we are talking patch version here) but not pytest?

Pushed. Note that in#12879 (comment),@timhoffm also stated that fixing this in 2.2.x might not be wanted, not sure if this is for the same reason.

AppVeyor is now failing with numerousE TypeError: cannot concatenate 'str' and 'MarkDecorator' objects, which I already started to investigate in#13182.

Errors fromhttps://ci.appveyor.com/project/matplotlib/matplotlib/builds/21606888/job/6jl1g3mg6jn1j2ol?fullLog=true are gone with the latest commit (btw, I’m not sure about the coding style in theps test). However, theTypeError: cannot concatenate 'str' and 'MarkDecorator' objects failures (1225 over 1229 FAILURES) are still there, as well as the four remaining ones,TypeError: coercing to Unicode: need string or buffer, MarkDecorator found.

I’ll keep investigating, but that is already going beyond my knowledge, so help would be appreciated.

I guess the solution is to be deduced fromhttps://docs.pytest.org/en/latest/mark.html#marker-revamp-and-iteration, but having never manipulated such things I’m a bit lost…

Backporting and testing is easy, fixing is something else. :p

pytest-dev/pytest#3576 might also be related.

attn@sandrotosi is this going to be a problem of debian?

(Might be worst noting that in the latestv2.2.x commit, all tests failing here are skipped)

Also I still don’t understand the Travis failure.

This looks like the thing we use to have an xserver on travis stopped working...

@ArchangeGabriel Be aware I added some commits (it seemed faster to just make the edits via the GH ui than to ask you to make the changes ), hope you do not mind.

ok, that seems to have gotten the python3 test running again, but py27 is failing inside of pytest startup...

@tacaswell Yes I’ve seen, no issue with that, you are very welcome! ;)

So Python 3.4 is working, Python 3.6 & 3.7 are failing with the same error as in#13182. AppVeyor is not working because the lack of tools to compare images makes it try to skip 1229 tests, and the skipping code is what is failing with newer pytest on Py2.

Regarding Debian, it should not be an issue:Stretch hasmatplotlib 2.0.0, whileBuster hasmatplotlib2 2.2.3 butpytest 3.10.1 (https://packages.debian.org/source/matplotlib andhttps://packages.debian.org/source/pytest).

(I’m investigating the py2 issue, already foundpytest-dev/pytest#3889, so likely have to go an higher pytest version)

Yup, fixed in 3.6.1:pytest-dev/pytest@b5a94d8

I’ll push a small commit to update to this version at least.

OK, so now need to re-pin downrerunfailures. I guess<6 will do, checking and pushing.

Wow, py2 actually passed in Travis. \o/ I’ll have a look in version differences between the different passing/failing builds, to see whether they are some more changes we should catch or if there is a real issue in pytest.

Small note: the working Py3.4 TravisCI is usingpytest 3.8.2, while the failing Py3.6/3.7 are usingpytest 4.1.1. Looking at thepytest changelog, I don’t see anything outstanding, but I would bet onpytest 4.1 being the culprit (and since I did not see anything relevant in the changes, I would say it’s apytest bug).

OK, got it. We need to backport#12316 (mainlydbac64f and46d3860, but others one are interesting too). I’ll do it tomorrow if needed, but if someone with appropriate rights can runmeseeksdev in the meantime so that we can at best win some time and at worst give me the appropriate way of backporting a multi-commit PR, that would be very welcomed.

CI went OK as expected. I’ve fixed mypytest>=3.6.1 commit, and also backported#12294 (but the backport was automatic, so I didn’t take care of the commit message).

I think this PR is now up for review/comments, especially if you want me to change some commit messages or coding style for manual changes.

@NelleV Not sure why you cycled, the CI gave the same result as just before. MacOS on Travis is broken trying to compile half of the universe before being able to install, so…

It might be necessary to backport#12615 to fix macOS builds.

Though it seems to be ffmpeg that fails, so maybe not.

we are not seeing this issue in master because we are trying to install a non-existing tap (Error: No available formula with the name "font-wenquanyi-zen-hei") so this whole line is not run and we do not try to install ffmpeg.

@ArchangeGabriel I cycle when patches merged in the branch may (or may not) fix the test issues. I don't necessarly try to deeply look at the whether the failed tests on the branch correspond to the tests fixed in a previous patch: it would take too much of our time to manually check this while restarting the CI only takes machine time.

@NelleV I see, makes sense. :)

So we are now passing with macOS too. What are the next steps for this to get merged?

@ArchangeGabriel You bug people until they review your pull request. The next core dev' that approves can merge it, so hopefully it should be fast!

@tacaswell this should be fine for Debian - thanks for checking!

also, small notice, we're about to start the freeze phase (ie no more new packages) for the next stable Debian release, so if you're planning on releasing mpl 2.x and 3.x this would be a good time :)

😬

I’ve updated the title to reflect more correctly what’s inside. ;)

Congrats on getting your first PR into Matplotlib!

Thanks! :)

@sandrotosi may try to do bug fix releases for 3.0.x and 2.2.x by end end of January.

Was this ever backported into 3.0.x?

I see the changes on the 2.2.x branch but not 3.0.x, e.g., in
https://github.com/matplotlib/matplotlib/blob/v3.0.x/lib/matplotlib/testing/conftest.py

No, we missed it on accident (see#12154 (comment) ).

Given that we are going to do a 3.1 rc, mixed on if we should do a 3.0.4 to put this in...