Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Add example code for current logo#13169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ImportanceOfBeingErnest commentedJan 13, 2019
Concerning the last point, I think the current logo (the one the matplotlib.org page) looks much nicer. This is mainly due to the orange bars not sitting tight against the 90°, -45° lines, but rather in between or on top. For the example it probably doesn't matter, but if someone is planning to use it for some official thing, I think it might be worth the effort to change it. Concerning the font, it seems to be Calibri, but modified with a transform (seehere) Possibly this can be applied to a |
timhoffm commentedJan 13, 2019
Turns out, the example code got broken because the alignment of barplots changed from 'edge' to 'center' in v2.0. Putting IMHO the logo itself looks quite good now. Didn't have time to look into the text so far. |
examples/misc/logos2.py Outdated
| plt.savefig('logo_xsmall.png') | ||
| ############################################################################## | ||
| # |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we can just remove the old stuff? People can always look at our old documentation to find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's the plan. I'll clean up the PR once I've found time to get the text in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
QuLogic commentedMar 26, 2019
anntzer commentedMar 26, 2019
Looking at the first version of the svg (both the version with text as text and the version with text as paths can be seen athttps://github.com/matplotlib/matplotlib/pull/5758/files) it looks like this is calibri bold with "manual" slanting ( It's too bad Matplotlib's logo is using a non-free font, but heh. |
timhoffm commentedMar 31, 2019
Updated the plot with the option to add the "matplotlib" text. @anntzer Thanks for the hint on the transform. I'm trying to do this with the matplotlib Transforms by However, the text is not slanted but is shifted. I suspect I'm overriding some default tranform for the fig text here and I should somehow chain these transforms. Unfortunately, I don't understand the transforms well enough :sad:. Can you give me a hint what to do? |
96c8a57 to7379c40CompareImportanceOfBeingErnest commentedMar 31, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The Now it seems the svg coordinate systems is reflected compared to the one used by matplotlib, so the slanting will need a positive instead of a negative angle. This angle seems to be 4.25° (since tan(4.25)=0.0743128). So in total, |
timhoffm commentedApr 30, 2019
Note: I've removed all the code for drawing the old logo. I don't think anybody will be interested in this. If so, they can still go back in history in the repo. |
examples/misc/logos2.py Outdated
| This example generates the currentmatplotliblogo. | ||
| Thanks to Tony Yu <tsyu80@gmail.com> for the logo design | ||
| Thanks to Tony Yu <tsyu80@gmail.com> for theoriginallogo design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does anybody know who has created the current logo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The log for the file goes back to4d11bf4, so JDH? There's not code there either, so hard to say. Possibly it came from some separate website repo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have moved the original logo credit to the credits page. It's better to collect all credits there and not scatter them throughout the documentation. If anybody wants to add credit for the current logo, please do there.
0d9af7e to199fd92Comparetimhoffm commentedMay 1, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
For review: Update:Rendered example from CI |
dstansby left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, thanks a lot for putting this together.
WeatherGod commentedMay 9, 2019 via email
Pretty sure it was Thomas's wife who did the logo re-design, or was thatthe website facelift? …On Thu, May 9, 2019 at 11:47 AM David Stansby ***@***.***> wrote: ***@***.**** approved this pull request. Looks good to me, thanks a lot for putting this together. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13169 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACHF6C3JHEHS2GP5WJS6ETPURBSLANCNFSM4GPTJYIA> . |
timhoffm commentedMay 10, 2019
I have moved the original logo credit to the credits page. It's better to collect all credits there and not scatter them throughout the documentation. If anybody wants to add credit for the current logo, please do there. |
jklymak commentedMay 10, 2019
Sorry if I missed discussion above, but the render you link did not find the correct font: |
anntzer commentedMay 10, 2019
I think it would be nice to keep the old logo around, e.g. in the history.rst page (which already has an even older logo as well). |
timhoffm commentedMay 10, 2019
@jklymak That is correct. The original font would be Calibri, but the font is not publically available in linux and I don't think we can add it to the repo due to copyright. |
jklymak commentedMay 10, 2019
But this isn’t even a bold font. You can’t use a font that looks ok? |
timhoffm commentedMay 10, 2019
We can use Carlito see here:#13169 (comment) Probably need to install this package to the doc building server: |
Uh oh!
There was an error while loading.Please reload this page.
timhoffm commentedMay 11, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Now using Carlito in CI:Rendered example from CI Thehistory page (CI) now contains the previous logo from this example. |
…169-on-v3.1.xBackport PR#13169 on branch v3.1.x (Add example code for current logo)




Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This adds code for creating a current logo (logo2.png). For the time being I've simply added the code to the existing logo example. We should decide later on the existing example can be removed (because it's an old version) or if we want to keep both.
This will still need some optimizations.
Open issues:
For review:
Rendered example from CI