Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify Text.get_usetex.#13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromanntzer:text
Jan 15, 2019
Merged

Simplify Text.get_usetex.#13166

jklymak merged 1 commit intomatplotlib:masterfromanntzer:text
Jan 15, 2019

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJan 12, 2019
edited
Loading

  • Make the module-level _wrap_text a text method instead, and don't make
    it yield anything as it is modifying the text object in-place anyways.
    (This avoids having to wonder where other textobj attributes come
    from.)
    Removed this as I realized there's an even simpler way to handle
    it, but would be better on top ofMake Text._get_layout simpler to follow. #12951.
  • text._usetex is never None becauseset_usetex already replaces
    None by the rc value, so we don't need to additionally validate in the
    getter.

Preliminary work towards fixing#13139 (comment) (#12951 would be needed too to avoid a rebase).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer changed the titlePreparatory Text cleanups.Simplify Text.get_usetex.Jan 12, 2019
set_usetex already prevents `self._usetex` to even be None.
@jklymakjklymak merged commit5a7e0ea intomatplotlib:masterJan 15, 2019
@anntzeranntzer deleted the text branchJanuary 15, 2019 18:22
@QuLogicQuLogic added this to thev3.1 milestoneJan 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@jklymak@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp