Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Simplify Text.get_usetex.#13166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesJan 12, 2019
set_usetex already prevents `self._usetex` to even be None.
6 tasks
jklymak approved these changesJan 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Make the module-level _wrap_text a text method instead, and don't makeRemoved this as I realized there's an even simpler way to handleit yield anything as it is modifying the text object in-place anyways.
(This avoids having to wonder where other textobj attributes come
from.)
it, but would be better on top ofMake Text._get_layout simpler to follow. #12951.
text._usetex
is never None becauseset_usetex
already replacesNone by the rc value, so we don't need to additionally validate in the
getter.
Preliminary work towards fixing#13139 (comment) (#12951 would be needed too to avoid a rebase).
PR Summary
PR Checklist