Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make FigureManagerWx more consistent with other backends.#13153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:more-wx

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJan 10, 2019•
edited
Loading

PR Summary

Builds on top of#13146 to avoid a rebase.
Note that unlike in#10606, FigureManagerWx is a pure-python class, not a wx Widget, so there's no problems with wxness of the constructor there.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

window : wxFrame
a wxFrame instance - wxpython.org/Phoenix/docs/html/Frame.html
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The link is broken and if anything the only link should be to the wxpython general docs at the top of the module (perhaps).

@jklymakjklymak marked this pull request as draftApril 23, 2021 16:32
@anntzeranntzer marked this pull request as ready for reviewJune 3, 2021 17:44
@anntzeranntzer marked this pull request as draftJune 4, 2021 12:33
@anntzeranntzerforce-pushed themore-wx branch 2 times, most recently from7e54812 to0986dadCompareJune 5, 2021 19:55
@anntzeranntzer marked this pull request as ready for reviewJune 6, 2021 10:04
@anntzeranntzer marked this pull request as draftJune 6, 2021 10:36
@anntzer
Copy link
ContributorAuthor

Because wx expects (AFAIU) parent widgets to be fully set up before children, I don't think it is possible to match the model of other backends where we first create the Canvas and then let the Manager create the toplevel window that hosts it :/

@anntzeranntzer closed thisJun 6, 2021
@anntzeranntzer deleted the more-wx branchJune 6, 2021 10:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp