Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update example Step Demo#13148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromtimhoffm:example-step
Jan 10, 2019
Merged

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedJan 10, 2019•
edited
Loading

PR Summary

  • Add a sentence on the purpose of the example.
  • Add markers for the data points so that the effect ofwhere is easier to see.
  • Remove the masked data set. I don't see what that should teach in context of the example. If somebody can explain the purpose, I'm happy to re-add it.

This is how it looks like

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good, but have we decided if we are planning to move most of the examples to OO?

@timhoffm
Copy link
MemberAuthor

Not sure. Can do if you want. - But it's also trivial to search and replace later.

@jklymak
Copy link
Member

Sure, well lets merge as an improvement, and we can disucss further whether we want to change examples going forward...

@jklymak
Copy link
Member

Merging w/o test CI - flake8 passed and the rendered pages look good.

@jklymakjklymak merged commit910f9fd intomatplotlib:masterJan 10, 2019
@timhoffmtimhoffm deleted the example-step branchJanuary 10, 2019 19:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

Assignees
No one assigned
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

2 participants
@timhoffm@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp