NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Drop pytest version check in setupext.py.#13073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:pytest-minversion-setupext

Jan 2, 2019

Merged

Drop pytest version check in setupext.py.#13073

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:pytest-minversion-setupext

Jan 2, 2019

Conversation

Copy link

Contributor

anntzer commentedJan 1, 2019

There's already a better check from the minversion entry in pytest.ini,
which will actually error out cleanly if trying to run the tests with a
too-old pytest.

(For example the setupext check did not prevent#12945 (comment), whereas the minversion in pytest.ini would have done so (#12975).)

Also that's one fewer place to update when bumping the pytest minversion.

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Drop pytest version check in setupext.py.

de77e29

There's already a better check from the minversion entry in pytest.ini,which will actually error out cleanly if trying to run the tests with atoo-old pytest.

anntzer added the Build label

Jan 1, 2019

anntzer added this to thev3.1 milestone

Jan 1, 2019