Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Don't explicitly add default include paths to Extensions#13064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 7 commits intomatplotlib:masterfromanntzer:setupext
Mar 13, 2019

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedDec 29, 2018•
edited
Loading

PR Summary

Closes#9737 and makes setupext.py 20% shorter.

Builds on top of#11964; once that PR is merged I'm happy to further split this one into smaller pieces to help review if needed.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
ContributorAuthor

rebased now that#11964 is merged.

@tacaswelltacaswell self-requested a reviewMarch 11, 2019 19:53
@tacaswelltacaswell merged commitdce1dc3 intomatplotlib:masterMar 13, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 13, 2019
@anntzeranntzer deleted the setupext branchMarch 13, 2019 14:06
@tacaswell
Copy link
Member

attn@sandrotosi@cgohlke@msarahan don't think this will cause you problems, but just flagging this a head of 3.1

msarahan reacted with thumbs up emoji

jklymak added a commit that referenced this pull requestMar 13, 2019
…064-on-v3.1.xBackport PR#13064 on branch v3.1.x (Don't explicitly add default include paths to Extensions)
thatch added a commit to third-party-oneoffs/matplotlib that referenced this pull requestOct 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@tacaswelltacaswellAwaiting requested review from tacaswell

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

setupext should not explicitly add /usr/{,local/}include to the include path
3 participants
@anntzer@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp