NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Fix vertical alignment of text#13029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 2 commits intomatplotlib:masterfromstefraynaud:bug_rotation_mode_center_baseline

Dec 23, 2018

Merged

Fix vertical alignment of text#13029

timhoffm merged 2 commits intomatplotlib:masterfromstefraynaud:bug_rotation_mode_center_baseline

Dec 23, 2018

Conversation

Copy link

Contributor

stefraynaud commentedDec 20, 2018

PR Summary

This solves#13028: whenrotation_mode='anchor' and"verticalaligment="center_baseline", the vertical alignment is wrong even ifrotation=0. The vertical position of text was badly computed in this configuration, and the PR solves the problem.

PR Checklist

Code isFlake 8 compliant

Fix vertical alignment of text

ba4e8db

This solves#13028.

Copy link

Member

jklymak commentedDec 21, 2018

This should get a test I think. Wascenter_baseline working at all withrotation_mode='anchor'?

Add test to make sure rotation_mode does break text position

6131166

... when rotation=0

Copy link

ContributorAuthor

stefraynaud commentedDec 21, 2018•
edited
Loading

@jklymak You are right. I added a test that makes sure settting rotation_mode doesn't change anything if rotation=0.

Copy link

Member

QuLogic commentedDec 23, 2018

Do you know ifrotation != 0 appears reasonable?

QuLogic approved these changes

Dec 23, 2018

View reviewed changes

Copy link

Member

timhoffm commentedDec 23, 2018

rotation != 0 seems to be reasonable:

plt.plot([0, 1], lw=0)plt.axvline(.5, linewidth=.5, color='.5')plt.axhline(.5, linewidth=.5, color='.5')N = 4for r in range(N):    plt.text(.5, .5, 'pP', color=plt.get_cmap('jet')(r/N), size=100, rotation=r/N*360, va='center_baseline', rotation_mode='anchor')

before:

after:

The rotation center is not at (0.5, 0.5) but at the edge of the "p". However, I'm unsure if that's supposed to happen, also it's the same before and after this PR. So if that's an issue it's a separate one.